Wireshark-commits: [Wireshark-commits] master-1.8 750cce3: The "not DNS" filter used UDP in the des

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 8 Apr 2014 19:34:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=750cce3684884113630e96577aaa71717e5df495
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-1.8
Repository: wireshark

Commits:

750cce3 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    The "not DNS" filter used UDP in the description but matched against
    TCP. DNS runs over both so update the filter to exclude both.
    
    Thanks to Yaron Fainstein for noticing this.
    
    Change-Id: I0c4d1fef7f8d725bf656cca87ba5908893fff0b2
    Reviewed-on: https://code.wireshark.org/review/1028
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 84a57cb2ebd2b9c7605bf56395d19d3be0a5feea)
    Reviewed-on: https://code.wireshark.org/review/1032
    

Actions performed:

    from  8a59bb5   [Automatic manuf, services and enterprise-numbers update for 2014-04-06]
    adds  750cce3   The "not DNS" filter used UDP in the description but matched against TCP. DNS runs over both so update the filter to exclude both.


Summary of changes:
 dfilters |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)