Wireshark-commits: [Wireshark-commits] master 84a57cb: The "not DNS" filter used UDP in the descrip

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 8 Apr 2014 19:24:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=84a57cb2ebd2b9c7605bf56395d19d3be0a5feea
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

84a57cb by Gerald Combs (gerald@xxxxxxxxxxxxx):

    The "not DNS" filter used UDP in the description but matched against
    TCP. DNS runs over both so update the filter to exclude both.
    
    Thanks to Yaron Fainstein for noticing this.
    
    Change-Id: I0c4d1fef7f8d725bf656cca87ba5908893fff0b2
    Reviewed-on: https://code.wireshark.org/review/1028
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  07ee5de   Get the UDP protocol number from a Wireshark header.
    adds  84a57cb   The "not DNS" filter used UDP in the description but matched against TCP. DNS runs over both so update the filter to exclude both.


Summary of changes:
 dfilters |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)