Wireshark-commits: [Wireshark-commits] master 2b5fc4e: The encoding of a string is *not* part of it

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 7 Apr 2014 23:14:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2b5fc4efdc2afd3349014669fb7bfad59c5d458c
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2b5fc4e by Guy Harris (guy@xxxxxxxxxxxx):

    The encoding of a string is *not* part of its type.
    
    So get rid of the commented-out FT_UCS2_LE; that would be handled as an
    FT_STRING, FT_UINT_STRING, or FT_STRINGZ with an encoding of
    ENC_UCS_2|ENC_LITTLE_ENDIAN.
    
    Change-Id: I828fc1ed49843a503ec70e6adaf6dadd256df407
    Reviewed-on: https://code.wireshark.org/review/996
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  172f5cd   Sort the values in value_strings that we'll treat as extended.
    adds  2b5fc4e   The encoding of a string is *not* part of its type.


Summary of changes:
 epan/ftypes/ftypes.h |    1 -
 1 file changed, 1 deletion(-)