URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=67cc46294141ee1af32c5d15080b08a525e0813f
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
67cc462 by AndersBroman (anders.broman@xxxxxxxxxxxx):
Don't use external function internaly to avoid multiple checks.
tvb_captured_length() -> tvb->length
tvb_captured_length_remaining(tvb, offset) -> (Inline) _tvb_captured_length_remaining()
tvb_get_ptr() -> ensure_contiguous()
Change-Id: I3540854c9b51ca9c3319b030c7d91b4aff976a26
Reviewed-on: https://code.wireshark.org/review/922
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 84bc050 In the string handling routines don't call tvb_get_...() inside the loops insted get the ptr and read directly avoiding the overhead of calling fast_ensure_contiguous() repeatibly.
adds 67cc462 Don't use external function internaly to avoid multiple checks. tvb_captured_length() -> tvb->length tvb_captured_length_remaining(tvb, offset) -> (Inline) _tvb_captured_length_remaining() tvb_get_ptr() -> ensure_contiguous()
Summary of changes:
epan/tvbuff.c | 59 ++++++++++++++++++++++++++++++++++++++++++++++-----------
1 file changed, 48 insertions(+), 11 deletions(-)