Wireshark-commits: [Wireshark-commits] master 35648de: Fix -Wabsolute-value in GTK SCTP Graph (Foun

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 15 Mar 2014 11:40:22 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=35648dec43c05f4b3a2845d9957106852d2c8f28
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

35648de by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    Fix -Wabsolute-value in GTK SCTP Graph (Found by Clang 3.5)
    
    sctp_graph_dlg.c:1562:18: error: taking the absolute value of unsigned type 'unsigned int' has no effect [-Werror,-Wabsolute-value]
    sctp_graph_dlg.c:1562:18: note: remove the call to 'abs' since unsigned values cannot be negative
    sctp_graph_dlg.c:1574:18: error: taking the absolute value of unsigned type 'unsigned int' has no effect [-Werror,-Wabsolute-value]
    sctp_graph_dlg.c:1574:18: note: remove the call to 'abs' since unsigned values cannot be negative
    
    Change-Id: If3cdce123256543a95fe0b596eee962e1d93d118
    Reviewed-on: https://code.wireshark.org/review/674
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  0d2dd00   Fix -Wabsolute-value in ICMP dissector (found by Clang 3.5)
    adds  35648de   Fix -Wabsolute-value in GTK SCTP Graph (Found by Clang 3.5)


Summary of changes:
 ui/gtk/sctp_graph_dlg.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)