Wireshark-commits: [Wireshark-commits] master 3094062: Use constants instead of vwr->STATS_LEN in s

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 15 Mar 2014 10:03:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=309406299dd694be8191024fd25a5e30d9f7c399
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3094062 by Guy Harris (guy@xxxxxxxxxxxx):

    Use constants instead of vwr->STATS_LEN in some cases.
    
    In some cases, we know, based on the FPGA code, what vwr->STATS_LEN is,
    so use that #define.
    
    While we're at it, replace some hardcoded numbers that represent the
    statistics trailer length with the appropriate #define.
    
    Also, combine two identical case arms for Ethernet into one.
    
    Change-Id: I0bdea8e5aab146094ad21fa7e67dca2913da688b
    Reviewed-on: https://code.wireshark.org/review/672
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  41c8cd6   Fix setting of STATS_LEN - it's what's in the file, not what we *generate*.
    adds  3094062   Use constants instead of vwr->STATS_LEN in some cases.


Summary of changes:
 wiretap/vwr.c |   18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)