Wireshark-commits: [Wireshark-commits] master-1.8 2d1d85f: Ensure that the input to strtoul ends wi

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 9 Mar 2014 11:46:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2d1d85fc67058b66b668978c50a483076e1c7b91
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master-1.8
Repository: wireshark

Commits:

2d1d85f by Evan Huus (eapache@xxxxxxxxx):

    Ensure that the input to strtoul ends with a null.
    
    Otherwise it runs past the end of the array into stack memory. Should fix the
    intermittent DVB-CI decryption test suite failures.
    
    Change-Id: Ice17497e661c8579baf3a546efcb5529beda6b49
    Reviewed-on: https://code.wireshark.org/review/559
    Tested-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/567
    

Actions performed:

    from  baffcd1   1.8.13 → 1.8.14.
    adds  2d1d85f   Ensure that the input to strtoul ends with a null.


Summary of changes:
 epan/dissectors/packet-dvbci.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)