Wireshark-commits: [Wireshark-commits] master ed1528d: Ensure that the input to strtoul ends with a

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 8 Mar 2014 18:30:18 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ed1528d339096288e7f9c11ffe1a6fe33bca7712
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ed1528d by Evan Huus (eapache@xxxxxxxxx):

    Ensure that the input to strtoul ends with a null.
    
    Otherwise it runs past the end of the array into stack memory. Should fix the
    intermittent DVB-CI decryption test suite failures.
    
    Change-Id: Ice17497e661c8579baf3a546efcb5529beda6b49
    Reviewed-on: https://code.wireshark.org/review/559
    Tested-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  ddd9d27   Tight array index guard in packet-umts_fp.c
    adds  ed1528d   Ensure that the input to strtoul ends with a null.


Summary of changes:
 epan/dissectors/packet-dvbci.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)