URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a6809ce9aa55ed593a292ff1713d9f826b10d2f0
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
a6809ce by Hadriel Kaplan (hadrielk@xxxxxxxxx):
Fix bytes view pane showing non-ASCII chars
The bytes view pane in Qt is showing non-ASCII characters in the right-hand
side. That's because the code is using isprint(), which is locale specific
and frequently includes non-ascii charscters such as the copyright symbol and
such. I wouldn't care, except some of those non-ASCII characters affects
the font height and makes it looks sloppy (the display output is set to a
fixed *width* font, but not fixed height font apparently).
Change-Id: Idd471c5fb769d3d67aa08bc507d168e686d48098
Reviewed-on: https://code.wireshark.org/review/548
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Actions performed:
from ee07cd9 Make buildbot happy : packet-btle.c:275:16: error: declaration of 'index' shadows a global declaration [-Werror=shadow]
adds a6809ce Fix bytes view pane showing non-ASCII chars
Summary of changes:
ui/qt/byte_view_text.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)