Wireshark-commits: [Wireshark-commits] master 8d234a0: More tvbuff API deprecation, comment expansi

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 26 Feb 2014 22:04:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8d234a0d8c6c974a374e36a58cd7b3d699866464
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8d234a0 by Guy Harris (guy@xxxxxxxxxxxx):

    More tvbuff API deprecation, comment expansion, and documentation updates.
    
    Do with tvb_get_stringz() what was done with tvb_get_string().
    
    Redo the comments for the string get routines to try to give more detail
    in a fashion that's a bit less hard to read.
    
    Warn, in comments, of the problems with using
    tvb_get_string()/tvb_get_stringz() (i.e., if your strings are non-ASCII,
    all bytes with the 8th bit set are going be replaced by the Unicode
    REPLACEMENT CHARACTER, and displayed as such).
    
    Warn, in a comment, of the problems with tvb_get_const_stringz() (i.e.,
    it gives you raw bytes, rather than guaranteed-to-be-valid UTF-8).
    
    Update documentation and release notes appropriately.
    
    Change-Id: Ibd3efb92a203861f507ce71bc8d04d19d9d38a93
    Reviewed-on: https://code.wireshark.org/review/327
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  1dff4e3   Remove trailing whitespace from asn1 .cnf & template.[hc] files. Regenerate dissectors.
    adds  8d234a0   More tvbuff API deprecation, comment expansion, and documentation updates.


Summary of changes:
 doc/README.dissector           |   54 ++++++++++++-------
 docbook/release-notes.asciidoc |   11 ++--
 epan/tvbuff.c                  |   10 ----
 epan/tvbuff.h                  |  113 ++++++++++++++++++++++++++++------------
 tools/checkAPIs.pl             |    1 +
 5 files changed, 123 insertions(+), 66 deletions(-)