Wireshark-commits: [Wireshark-commits] master 2f23977: More explanation of example heuristic code.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 25 Feb 2014 13:38:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2f239772e6901b4f3260d34f4566d52d014441ce
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2f23977 by Evan Huus (eapache@xxxxxxxxx):

    More explanation of example heuristic code.
    
    Approach suggested by Jeff seems right to me:
    https://www.wireshark.org/lists/wireshark-dev/201402/msg00198.html
    
    Change-Id: I3d54cb49e2f0027ee79f68a633f57382101241b5
    Reviewed-on: https://code.wireshark.org/review/350
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  42ce748   Just use proto_tree_add_item() for an EBCDIC string.
    adds  2f23977   More explanation of example heuristic code.


Summary of changes:
 doc/packet-PROTOABBREV.c |   27 ++++++++++++++++-----------
 1 file changed, 16 insertions(+), 11 deletions(-)