Wireshark-commits: [Wireshark-commits] master fa02368: EDNS0 DO bit in Z field is decode incorrect

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 16 Feb 2014 14:08:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fa02368c959ac7a296d3590b1882abfb8abe1d03
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fa02368 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    EDNS0 DO bit in Z field is decode incorrect
    
    Z field of edns0 in Additinal records is decoded to text description incorrectly (wrong bitmask)
    
    Found by  Jittinan Suwanrueangsri
    Closed-Bug: 9767
    
    Change-Id: I8171b211cce79cb096a0f354764992f5cb18617c
    Reviewed-on: https://code.wireshark.org/review/226
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  1995e42   Stack overflow after selecting data when filter is applied that has no results (Wireshark Qt)
    adds  fa02368   EDNS0 DO bit in Z field is decode incorrect


Summary of changes:
 epan/dissectors/packet-dns.c |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)