Wireshark-commits: [Wireshark-commits] master 627069c: openSAFETY: Reduce overload and display gap

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 14 Feb 2014 16:12:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=627069c20c01cffcd81fa38d7f0c05e95e2f7061
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

627069c by Roland Knall (roland.knall@xxxxxxxxxxxxxxxxx):

    openSAFETY: Reduce overload and display gap data
    
     Up until now, openSAFETY hooked into a heuristic filter for epl
     and dissected the whole package, handing back some epl header
     information by calling epl again. This was time-consuming and
     on a busy network led to an increase in dropped packages and
     memory usage, as well as unresponsivness.
    
     This patch only takes the payload data of epl frames, and
     therefore greatly reduces the dissection overhead of openSAFETY.
    
     On a second note, intergap data between safety frames is now
     being displayed as Data, but only if the option for doing so
     is specifically enabled in the openSAFETY preferences, as it
     changes the behaviour of the dissector output.
    
     Upd: Because of the gap handling, some frames where marked
     as being truncated, although they were not, or did not contain
     openSAFETY frames at all. In the course of the fix for this,
     the byte copying for the byte swap with MBTCP has been moved
     to only occur when needed, and is additionaly guarded.
    
     Upd2: Identation and comment fixes
    
     Upd3: Change memcpy to memdup and move find_dissector ( "data" )
     to proto_reg_handoff
    
    PLK: Store data dissector pointer
    
     Move the if-clause to proto_reg_handoff as documented
     in comment of Change-id: 191
    
    Change-Id: I3038ed465900a2b5e63b3a0967abd62a4c66f318
    Reviewed-on: https://code.wireshark.org/review/191
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  5c1a348   Make checkAPI Happy
    adds  627069c   openSAFETY: Reduce overload and display gap data


Summary of changes:
 epan/dissectors/packet-epl.c        |    9 ++--
 epan/dissectors/packet-opensafety.c |   95 +++++++++++++++++++++++++----------
 2 files changed, 73 insertions(+), 31 deletions(-)