http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=54764
User: guy
Date: 2014/01/14 05:23 AM
Log:
Don't cast away constness. In one place, this requires that we use one
pointer while we're filling in a string and then assigning it to a const
pointer when we're done.
Don't use guint16 as a size value; it does no good (it doesn't magically
protect you againt too-long strings), it runs the potential risk of
overflow, it doesn't save time for arithmetic (32-bit or 64-bit
arithmetic may well be faster, and will at least be as fast), and it
doesn't save space (if it fits in a register, you save nothing, and if
it's on the stack, there will probably be padding.
Directory: /trunk/epan/dissectors/
Changes Path Action
+9 -7 packet-pvfs2.c Modified