Wireshark-commits: [Wireshark-commits] rev 52979: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: eapache@xxxxxxxxxxxxx
Date: Wed, 30 Oct 2013 02:09:35 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=52979

User: eapache
Date: 2013/10/30 02:09 AM

Log:
 Replace some proto_tree_add_string_format with proto_tree_add_item +
 proto_tree_set_text - the string was not the important part, the formatting was.
 We were passing the string directly from tvb_get_ptr, but this meant that if the
 packet didn't contain a null-terminator we would run off the end. Since the
 string comes straight from the packet, just let _add_item handle the length
 calculations etc efficiently, and set the display later.
 
 Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9323
 
 I'm a bit confused honestly why most of these are being set hidden after being
 added and formatted, but at least there are no memory errors anymore.

Directory: /trunk/epan/dissectors/
  Changes    Path             Action
  +19 -11    packet-http.c    Modified