Wireshark-commits: [Wireshark-commits] rev 50282: /trunk/epan/ /trunk/epan/: tvbuff.c

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: cmaynard@xxxxxxxxxxxxx
Date: Mon, 01 Jul 2013 05:23:19 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=50282

User: cmaynard
Date: 2013/06/30 10:23 PM

Log:
 There are a few dissectors that pass the return value of tvb_length_remaining() as the size argument to the tvb_format_*() functions.  Try to do something sane if that value happens to be -1 (or negative in general).  One such example is packet-bthfp.c, as found and reported by Coverity in CID 1035325 (Improper use of negative value).
 
 Note: There are other ways to handle this of course, but this fix is suitable for backporting to both 1.10 and 1.8, as it does not break binary compatibility.  Is there a better way to fix this though?  For now, schedule this for backport.

Directory: /trunk/epan/
  Changes    Path          Action
  +12 -9     tvbuff.c      Modified