Wireshark-commits: [Wireshark-commits] rev 50277: /trunk/ /trunk/epan/dissectors/: packet-iax2.c /t

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: guy@xxxxxxxxxxxxx
Date: Mon, 01 Jul 2013 02:51:48 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=50277

User: guy
Date: 2013/06/30 07:51 PM

Log:
 Consistently maintain the callState member of an iax2_info_t structure
 as a voip_call_state value; don't have it sometimes a voip_call_state
 and sometimes a frame subtype.
 
 This should squelch some complaints from newer versions of Clang about
 unnecessary array-bounds checks - the array-bounds checks are done on
 frame subtypes, where they *are* necessary (nothing prevents an
 untrustworthy IAX2 implementation or an untrustworthy capture file
 writer from putting an arbitrary value in the packets), not on
 voip_call_state values (where it was only necessary because the value
 wasn't, in that case, a voip_call_state value, it was a frame subtype
 cast to a voip_call_state).

Directory: /trunk/epan/dissectors/
  Changes    Path             Action
  +46 -2     packet-iax2.c    Modified

Directory: /trunk/ui/gtk/
  Changes    Path            Action
  +2 -45     voip_calls.c    Modified