Wireshark-commits: [Wireshark-commits] rev 47745: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: guy@xxxxxxxxxxxxx
Date: Tue, 19 Feb 2013 07:06:55 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=47745

User: guy
Date: 2013/02/18 11:06 PM

Log:
 calc_checksum() should be passed the length of the block to be
 checksummed, which is the length of the TPDU, not that length + 1.
 
 Calculate the TPDU length correctly - use
 tvb_reported_length_remaining(), not tvb_length_remaining() (we want the
 *actual* length, not the amount of captured data we have), and take the
 offset handed to the dissector routine into account.  Don't take the
 length indicator into account for TPDUs with user data, as they run to
 the end of the lower-level packet containing the TPDU(s).  The CLTP UD
 TPDU contains user data.
 
 Note that this dissects both COTP *and* CLTP (that's why it's
 "packet-ositp.c", not "packet-cotp.c").
 
 Separate some groups of #includes with blank lines.

Directory: /trunk/epan/dissectors/
  Changes    Path              Action
  +42 -11    packet-ositp.c    Modified