Wireshark-commits: [Wireshark-commits] rev 46099: /trunk/ /trunk/: capture_win_ifnames.c

Date: Wed, 21 Nov 2012 00:44:22 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=46099

User: guy
Date: 2012/11/20 04:44 PM

Log:
 When dumpcap is being run by another program, its standard error gets
 consumed by that program, and that program only ends up reporting one of
 those errors.  Therefore, only log one of them; we're seeing errors in
 the buildbot, and we want the more detailed error, so don't log a
 message after GetInterfaceFriendlyNameFromDeviceGuid() returns an error,
 just rely on the error logged by
 GetInterfaceFriendlyNameFromDeviceGuid().
 
 Ultimately, we don't want to print anything to the standard output or
 error at all, as that stuff ends up being consumed by the program in
 question; we should either ignore the error (if it's an "expected"
 error) or report it through the API so the the caller can, in turn,
 report it appropriately.

Directory: /trunk/
  Changes    Path                     Action
  +1 -3      capture_win_ifnames.c    Modified