Wireshark-commits: [Wireshark-commits] rev 45790: /trunk/epan/ /trunk/epan/dissectors/: packet-ntp.

Date: Thu, 25 Oct 2012 22:26:52 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=45790

User: morriss
Date: 2012/10/25 03:26 PM

Log:
 Fix problem where NTP times with the high-bit set to 0 (which RFC 2030
 chapter 3 has redefined to mean years *after* 2036) were being represented as
 times prior to 1968.
 
 This has been broken since r35840 (apparently not many people see NTP
 timestamps beyond 2036 :-)): apparently I over-optimized packet-ntp's code
 while copying it into proto.c: that temporary variable is necessary for the
 unsigned math to happen correctly before assigning the result to the (signed)
 time_t.
 
 Leave a comment in the code indicating why the temporary variable is needed.
 Copy that comment to packet-ntp.c.
 
 Fix the same problem in ntp_to_nstime(): it also did not use the temporary variable.

Directory: /trunk/epan/dissectors/
  Changes    Path            Action
  +16 -3     packet-ntp.c    Modified

Directory: /trunk/epan/
  Changes    Path          Action
  +17 -7     proto.c       Modified