Wireshark-commits: [Wireshark-commits] rev 44980: /trunk/epan/ /trunk/epan/: packet.c

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: darkjames@xxxxxxxxxxxxx
Date: Tue, 18 Sep 2012 19:29:00 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=44980

User: darkjames
Date: 2012/09/18 12:29 PM

Log:
 Revert r44978: dissector_add_uint: Legalize formerly improper use of the API when calling it with pattern value of 0
 
 dissector_add_uint() is *not only* used by tcp.port/udp.port dissector tables where 0 is not valid port number,
 in some dissector tables 0 is valid protocol number, packet type, etc..
 
 Sample dissectors using dissector_add_uint(.pattern = 0):
   packet-ansi_637.c:2348: dissector_add_uint("ansi_a.sms", 0, ansi_637_trans_handle);
   packet-cip.c:6017:      dissector_add_uint("cip.class.iface", 0, cip_class_generic_handle );
   packet-lon.c:723:       dissector_add_uint("cnip.protocol", 0, lon_handle);
   packet-q931.c:3599:     dissector_add_uint("lapd.sapi", LAPD_SAPI_Q931 /* 0 */, q931_handle);

Directory: /trunk/epan/
  Changes    Path          Action
  +39 -46    packet.c      Modified