Wireshark-commits: [Wireshark-commits] rev 44322: /trunk/epan/ /trunk/epan/: proto.c

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: morriss@xxxxxxxxxxxxx
Date: Wed, 08 Aug 2012 03:02:28 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=44322

User: morriss
Date: 2012/08/07 08:02 PM

Log:
 Move the pi==NULL test into TRY_TO_FAKE_THIS_REPR.
 
 Since the tree will only be NULL here if someone messed up in proto.c and
 since pi will only be NULL if tree is NULL, assert out if either of them are
 NULL (don't use DISSECTOR_ASSERT() since such a condition wouldn't be the
 dissector writer's fault).
 
 Use TRY_TO_FAKE_THIS_REPR in ptvcursor_add_text_with_subtree().
 
 We've had TRY_TO_FAKE_THIS_REPR for a long time now, don't wrap it in #if 1.
 
 new_field_info() doesn't return NULL so don't check for it returning NULL in
 ptvcursor_add().

Directory: /trunk/epan/
  Changes    Path          Action
  +19 -99    proto.c       Modified