Wireshark-commits: [Wireshark-commits] rev 40951: /trunk/ui/gtk/ /trunk/ui/gtk/: rtp_player.c

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: jmayer@xxxxxxxxxxxxx
Date: Fri, 10 Feb 2012 07:16:29 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=40951

User: jmayer
Date: 2012/02/09 11:16 PM

Log:
 Sean Bright <sean.bright@xxxxxxxxx>:
 
 In r37159, the following change was made to ui/gtk/rtp_player.c:
 
 @@ -1654,9 +1636,7 @@
         GtkWidget *dialog;
 
         /* we should never be here if we are in PLAY and !PAUSE */
 -       if(!rtp_channels->stop&&  !rtp_channels->pause){
 -               exit(10);
 -       }
 +       g_assert(!rtp_channels->stop&&  !rtp_channels->pause);
 
 
 The logic, however, was not negated properly.  The correct assertion should be:
 
         g_assert(rtp_channels->stop || rtp_channels->pause);
 
 With the current code, the RTP player causes a crash for me when pressing the
 'Play' button.

Directory: /trunk/ui/gtk/
  Changes    Path            Action
  +1 -1      rtp_player.c    Modified