Wireshark-commits: [Wireshark-commits] rev 39841: /trunk/plugins/profinet/ /trunk/plugins/profinet/

Date: Tue, 15 Nov 2011 05:37:57 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=39841

User: guy
Date: 2011/11/14 09:37 PM

Log:
 OK, *that's* what Clang Cat was going on about:
 
 	packet-dcerpc-pn-io.c:8438:17: warning: Although the value
 	stored to 'prm_flag2' is used in the enclosing expression, the
 	value is never actually read from 'prm_flag2'
 
 OK, thanks for telling me that, technically,
 
 	prm_flag1 = prm_flag2 = 0;
 
 can be implemented by storing the 0 into prm_flag1 directly rather than
 storing 0 into prm_flag2 and copying it to prm_flag1.  Yes, you can haz
 cheeseburger.
 
 I guess it would matter if we were actually depending on some
 side-effect of fetching prm_flag2, but we're not.  Rewrite this one to
 squelch the complaint.

Directory: /trunk/plugins/profinet/
  Changes    Path                     Action
  +2 -1      packet-dcerpc-pn-io.c    Modified