Wireshark-commits: [Wireshark-commits] rev 37204: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: morriss@xxxxxxxxxxxxx
Date: Tue, 17 May 2011 18:58:44 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=37204

User: morriss
Date: 2011/05/17 11:58 AM

Log:
 As suggested by Chris: use val_to_str_const() instead of match_strval() plus a
 NULL-return check.
 
 Use val_to_str_const instead of val_to_str() in a couple places where the string
 is constant.
 
 Use val_to_str() instead of blindly passing the return value from match_strval()
 into a format routine (to ensure a non-NULL string pointer).  A couple of these
 were cases where it could not actually return NULL, but I changed it for
 consistency.
 
 Store the return value of match_strval() rather than calling it repeatedly.

Directory: /trunk/epan/dissectors/
  Changes    Path                  Action
  +20 -30    packet-amqp.c         Modified
  +1 -3      packet-ansi_637.c     Modified
  +15 -17    packet-gsm_a_gm.c     Modified
  +5 -5      packet-hci_h1.c       Modified
  +2 -2      packet-ieee80211.c    Modified
  +28 -29    packet-ncp-nmas.c     Modified
  +45 -42    packet-ncp-sss.c      Modified
  +1 -5      packet-rpc.c          Modified
  +13 -15    packet-ses.c          Modified
  +1 -10     packet-spp.c          Modified