http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=36468
User: morriss
Date: 2011/04/04 07:18 PM
Log:
From Felix Kraemer: fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5694 :
This patch adds the capability to create BACnet statistics trees.
Find the respective menu items under 'Statistics->BACnet'.
Packets can be sorted by different criteria:
- Src/Dst IP adresses
- Instance ID
- Object Type
- Service
From me:
- Don't use C++/C99-style comments.
- Name variables for tick_stat_node() don't need to be static.
- Change updateBacnetInfoValue() to require 'data' to be ep_ allocated. Change
the couple of calls that did not send in ep_ allocated data to do so.
- Change one or two functions to be static.
- Do not use (memory-unsafe) g_sprintf().
- Use ep_strconcat() instead of leaking memory with g_strconcat().
- Put back one if(tree) that doesn't appear to do any harm.
- Remove variable declarations and #includes from the header file.
Directory: /trunk/epan/dissectors/
Changes Path Action
+1 -0 Makefile.common Modified
+371 -122 packet-bacapp.c Modified
+42 -0 packet-bacapp.h Added
Directory: /trunk/
Changes Path Action
+4 -0 AUTHORS Modified
Directory: /trunk/epan/wslua/
Changes Path Action
+2 -0 taps Modified