Wireshark-commits: [Wireshark-commits] rev 35933: /trunk/ /trunk/epan/dissectors/: packet-btamp.c p

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: guy@xxxxxxxxxxxxx
Date: Sat, 12 Feb 2011 19:59:44 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=35933

User: guy
Date: 2011/02/12 11:59 AM

Log:
 The lack of _WITH_PHDR in WTAP_ENCAP_BLUETOOTH_H4 means there's no
 pseudo-header, and hence there's no direction indication. Don't set
 pinfo->p2p_dir for it.  Use WTAP_ENCAP_BLUETOOTH_H4_WITH_PHDR, not
 WTAP_ENCAP_BLUETOOTH_H4, for capture files where we have the direction.
 
 Don't assume pinfo->p2p_dir is either P2P_DIR_SENT or P2P_DIR_RECV when
 setting the info column in various Bluetooth dissectors; it might be
 unknown.
 
 In the HCI H4 dissector, put the direction into the info column
 regardless of whether we have a type match or not; the dissectors for
 HCI packet types appear to assume it's been set (as they put a blank at
 the beginning of the stuff they append to the direction).

Directory: /trunk/epan/dissectors/
  Changes    Path                 Action
  +19 -1     packet-btamp.c       Modified
  +19 -1     packet-btl2cap.c     Modified
  +20 -2     packet-btobex.c      Modified
  +18 -2     packet-btrfcomm.c    Modified
  +0 -1      packet-frame.c       Modified
  +20 -5     packet-hci_h4.c      Modified

Directory: /trunk/wiretap/
  Changes    Path          Action
  +3 -3      btsnoop.c     Modified
  +1 -1      hcidump.c     Modified