Wireshark-commits: [Wireshark-commits] rev 34640: /trunk/ /trunk/epan/dissectors/: Makefile.common

Date: Mon, 25 Oct 2010 01:43:57 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=34640

User: morriss
Date: 2010/10/24 06:43 PM

Log:
 From Thomas Boehne via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5324 :
 
 The company I work for uses two proprietary protocols, for which I initially
 developed  wireshark plugins. Now we would like to integrate them into the
 public wireshark repository. 
 
 I followed the READMEs and converted the plugins into a static dissectors. I
 cleaned up the code until checkAPI.pl was silent, translated all terms to
 english and ran randpkt and fuzz-testing for a long time. All that I found was
 a bug in a different dissector.
 
 From me:
 - Fold the header files into the dissectors
 - Clean up some memory leaks
 - Strengthen the heuristics of adwin-config (the TCP heuristics are still pretty
   weak)
 - Make packet-adwin.c a "new style" dissector 
 - Use find_or_create_conversation()
 - Remove most of the check_col()'s

Directory: /trunk/epan/dissectors/
  Changes    Path                     Action
  +2 -0      Makefile.common          Modified
  +742 -0    packet-adwin-config.c    Added
  +1449 -0   packet-adwin.c           Added

Directory: /trunk/epan/
  Changes    Path              Action
  +2 -0      CMakeLists.txt    Modified

Directory: /trunk/
  Changes    Path          Action
  +4 -1      AUTHORS       Modified