Wireshark-commits: [Wireshark-commits] rev 33888: /trunk/gtk/ /trunk/gtk/: new_packet_list.c

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: wmeier@xxxxxxxxxxxxx
Date: Mon, 23 Aug 2010 14:08:39 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=33888

User: wmeier
Date: 2010/08/23 07:08 AM

Log:
 new_packet_list_column_button_pressed_cb(): return gboolean (not void): it's an event callback;
 Note:
  the original code:
    static void new_packet_list_column_button_pressed_cb() {
      ...
      packet_list_popup(...);
      }
  the revised code:
    static gboolean new_packet_list_column_button_pressed_cb() {
      ...
      return packet_list_popup(...);
      }
 
  My guess is that the original code happened to work 
  on some?/all? supported platforms depending upon the actual
  details of the generated calling_sequence/return code.
 ---------------
 Also: 
 - new_packet_list_column_button_pressed_cb(): 'path' arg is unused;
 - new_packet_list_double_click_cb(): user_data arg is unused so 
   don't supply same in the g_signal_connect.

Directory: /trunk/gtk/
  Changes    Path                 Action
  +4 -6      new_packet_list.c    Modified