Wireshark-commits: [Wireshark-commits] rev 32812: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: morriss@xxxxxxxxxxxxx
Date: Fri, 14 May 2010 19:27:13 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=32812

User: morriss
Date: 2010/05/14 12:27 PM

Log:
 Rework SMS reassembly:
 
 - Take out the if(tree) because for reassembly to work we need to do the
   reassembly on the first pass.
 - Remove the (confusing) "try_dissect_message_fragment" preference (which
   caused us to dissect the message fragments) and replace it with a "reassembly"
   preference.  Dissect the message fragments regardless of whether reassembly is
   enabled or not (it's just SMS).  This solves the user confusion reported in
   https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4232 .
 - Add the text of the SMS using proto_tree_add_string*() so that we an filter on
   the text.

Directory: /trunk/epan/dissectors/
  Changes    Path                Action
  +142 -127  packet-gsm_sms.c    Modified