Wireshark-commits: [Wireshark-commits] rev 32526: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: morriss@xxxxxxxxxxxxx
Date: Wed, 21 Apr 2010 00:47:59 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=32526

User: morriss
Date: 2010/04/20 05:47 PM

Log:
 From Peter Harris via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4701 :
 
 The ChangeProperty request always calls LISTofBYTE, which always tries to
 dissect at least one byte, even when the request is empty. This causes
 Wireshark to put a big, red, scary "Malformed Packet" entry in the dissection.
 
 Also, ChangeProperty only dissects (data_length) bytes. data_length is "number
 of units", and units may be 16 or 32-bit entities. In this case, the dissected
 data will be truncated.
 
 First reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4481#c10
 
 The attached patch fixes these two bugs.

Directory: /trunk/epan/dissectors/
  Changes    Path                   Action
  +19 -2     packet-x11.c           Modified
  +4 -0      x11-declarations.h     Modified
  +6 -2      x11-fields             Modified
  +4 -0      x11-register-info.h    Modified