Wireshark-commits: [Wireshark-commits] rev 31562: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: guy@xxxxxxxxxxxxx
Date: Tue, 19 Jan 2010 01:16:05 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=31562

User: guy
Date: 2010/01/18 05:16 PM

Log:
 Even better - don't use a global variable in the first place, as its
 value isn't used outside dissect_sss_request().
 
 Get rid of some unused value_strings while we're at it; they duplicate
 value_strings in packet-ncp-nmas.c, and if they're really needed here,
 there should probably be only one instance, in, for example, the NCP
 dissector.
 
 Get rid of some unused variables, use -1 for "to the end of the tvbuff",
 don't use "subverb" unless we've actually fetched its value.

Directory: /trunk/epan/dissectors/
  Changes    Path                Action
  +13 -53    packet-ncp-sss.c    Modified