Wireshark-commits: [Wireshark-commits] rev 30481: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: wmeier@xxxxxxxxxxxxx
Date: Sat, 10 Oct 2009 21:13:20 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=30481

User: wmeier
Date: 2009/10/10 02:13 PM

Log:
 Replace use of GMemChunk by se_alloc;
 
 This fixes a major memory leak in the NCP dissector
 caused by the fact that "in recent versions of GLib" (>= 2.10 ?)
 g_mem_chunk_destroy doesn't actually free up the mem_chunk memory.
 
 Note that there still appears to be one or more smaller
 memory leaks somehow associated with NCP dissection.
 
 Example:
 
 A 40M capture file with mostly NCP frames which resulted in a memory
 usage increase of about 20M each time the file was reloaded now results 
 in a 400K-800K memory usage increase each time the file is reloaded.
 
 (If NCP dissection is disabled, there is minimal memory expansion
 each time the file is reloaded).

Directory: /trunk/epan/dissectors/
  Changes    Path                  Action
  +13 -1     packet-ncp.c          Modified
  +20 -76    packet-ncp2222.inc    Modified