Wireshark-commits: [Wireshark-commits] rev 29881: /trunk/ /trunk/: capture_sync.c dumpcap.c

Date: Sun, 13 Sep 2009 17:46:11 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=29881

User: morriss
Date: 2009/09/13 10:46 AM

Log:
 Don't use SIGUSR1 to tell dumpcap to exit, use SIGINT: SIGINT is traditionally
 used for this purpose and using it also prevents the 2 signals the child gets:
 	- the user's Ctrl-C (which is sent as a SIGINT to both *shark and its
 	  child dumpcap)
 	- the signal *shark generates to shut down the child
 
 from colliding (and running 2 signal handlers in the child).
 
 It might be possible for tshark to not send the signal at all when it gets
 SIGINT, but it doesn't do any harm now.
 
 Also, do not call g_log() within the signal handler: doing so can cause
 aborts (if g_log is being called by the process when the signal comes, the
 2nd entrance into g_log is detected as a recursion).
 
 This fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2767

Directory: /trunk/
  Changes    Path              Action
  +3 -3      capture_sync.c    Modified
  +17 -38    dumpcap.c         Modified