Wireshark-commits: [Wireshark-commits] rev 29213: /trunk/ /trunk/epan/dissectors/: packet-kerberos.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: sahlberg@xxxxxxxxxxxxx
Date: Tue, 28 Jul 2009 13:01:44 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=29213

User: sahlberg
Date: 2009/07/28 06:01 AM

Log:
 When we passed the crytobuffer to krb5_c_decrypt() we never actually 
 verified that we did have enough data in the buffer/tvb, which could 
 lead to a SEGV.
 (for example if we enable KRB5 decryption but we do NOT use TCP 
 reassembly, and the encrypted data goes beyong the end of the current 
 segment)
 
 
 Change the signature to decrypt_krb5_data() to take a TVB instead of a 
 buffer+length.
 Actually check that we do have the entire encrypted PDU before calling 
 out to the kerberos libraries.

Directory: /trunk/epan/dissectors/
  Changes    Path                 Action
  +60 -18    packet-kerberos.c    Modified
  +1 -2      packet-kerberos.h    Modified
  +7 -9      packet-kink.c        Modified
  +8 -4      packet-spnego.c      Modified

Directory: /trunk/asn1/spnego/
  Changes    Path                        Action
  +6 -2      packet-spnego-template.c    Modified