Wireshark-commits: [Wireshark-commits] rev 25402: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

Date: Fri, 30 May 2008 05:19:58 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=25402

User: guy
Date: 2008/05/29 10:19 PM

Log:
 g_strcmp0() only shows up on the Intarweb in documentation for some
 testing version of GLib; it doesn't appear to exist in any current
 versions.  There's no need to "gracefully" handle NULL (whatever
 "gracefully" means in this context - NULL compares less than any real
 string?), as we already checked whether mac_name is null, and we're
 comparing it against a string constant; just use strcmp().
 
 In ssh_gslist_compare_strings(), check for null pointers for now.
 
 strcmp() (and strcmp-alikes) don't return a boolean, they return a value
 such that comparing strings with a particular operator is done by
 comparing the result of strcmp() with 0 using that operator; do that, to
 make it clearer that the strings are being compared for equality.

Directory: /trunk/epan/dissectors/
  Changes    Path            Action
  +10 -4     packet-ssh.c    Modified