Wireshark-commits: [Wireshark-commits] rev 22587: /trunk/ /trunk/gtk/: capture_dlg.c capture_if_dlg

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: morriss@xxxxxxxxxxxxx
Date: Wed, 22 Aug 2007 16:30:21 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=22587

User: morriss
Date: 2007/08/22 04:30 PM

Log:
 Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1757 :
 
 Try to call get_interface_descriptive_name() as little as possible (storing
 the result in capture_opts) to avoid a performance hit during live capture
 (especially if you have lots of interfaces) and to avoid leaking memory.
 
 One issue with this is that capture_opts.c cannot (without adding significant
 dependencies) set the iface_descr so readers of that field (only gtk/main.c
 and tshark.c) use a macro to (set if not already set and) get the value of
 that field.

Directory: /trunk/gtk/
  Changes    Path                Action
  +7 -1      capture_dlg.c       Modified
  +7 -0      capture_if_dlg.c    Modified
  +33 -27    main.c              Modified

Directory: /trunk/
  Changes    Path                  Action
  +14 -0     capture_opts.c        Modified
  +14 -0     capture_opts.h        Modified
  +2 -0      capture_ui_utils.c    Modified
  +1 -5      summary.c             Modified
  +2 -4      tshark.c              Modified