http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=20670
User: gerald
Date: 2007/02/01 06:40 PM
Log:
Copy over NEWS and release-notes.xml from the trunk.
Copy over the H.248 dissector from the trunk.
Copy over revs 20562, 20648, 20658:
------------------------------------------------------------------------
r20562 | jmayer | 2007-01-26 00:09:20 -0800 (Fri, 26 Jan 2007) | 3 lines
Changed paths:
M /trunk/epan/dissectors/packet-tftp.c
If there is just a tftp response without a prior request,
dissection would fail with dissector assert.
------------------------------------------------------------------------
r20648 | ulfl | 2007-01-30 22:45:46 -0800 (Tue, 30 Jan 2007) | 1 line
Changed paths:
M /trunk/packaging/nsis/wireshark.nsi
slightly better explain the user's guide "component"
------------------------------------------------------------------------
r20658 | gerald | 2007-01-31 15:26:29 -0800 (Wed, 31 Jan 2007) | 15 lines
Changed paths:
M /trunk/epan/to_str.c
From Andrej Mikus:
IMO, the function should return an error string instead of cowardly
bailing out with an empty string.
inet_ntop does the latter by default, so it does not need any additional
check, just passing buf_len instead of INET6_ADDRSTRLEN.
At the other side I like the check you made into ip_to_str_buf.
My proposal would be to combine the patches and use MAX_IP_STR_LEN,
and approach below for both IPv4 and IPv6 in address_to_str_buf.
Have the error string return a more descriptive clue.
------------------------------------------------------------------------
Directory: /trunk-0.99.5/epan/dissectors/
Changes Path Action
+6 -2 packet-tftp.c Modified
Directory: /trunk-0.99.5/docbook/
Changes Path Action
+10 -7 release-notes.xml Modified
Directory: /trunk-0.99.5/epan/
Changes Path Action
+14 -9 to_str.c Modified
Directory: /trunk-0.99.5/packaging/nsis/
Changes Path Action
+1 -1 wireshark.nsi Modified
Directory: /trunk-0.99.5/
Changes Path Action
+60 -42 NEWS Modified