Wireshark-commits: [Wireshark-commits] rev 20658: /trunk/epan/ /trunk/epan/: to_str.c

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: gerald@xxxxxxxxxxxxx
Date: Wed, 31 Jan 2007 23:26:31 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=20658

User: gerald
Date: 2007/01/31 11:26 PM

Log:
 From Andrej Mikus: 
 
   IMO, the function should return an error string instead of cowardly
   bailing out with an empty string.
 
   inet_ntop does the latter by default, so it does not need any additional
   check, just passing buf_len instead of INET6_ADDRSTRLEN.
   
   At the other side I like the check you made into ip_to_str_buf.
 
   My proposal would be to combine the patches and use MAX_IP_STR_LEN,
   and approach below for both IPv4 and IPv6 in address_to_str_buf.
 
 Have the error string return a more descriptive clue.

Directory: /trunk/epan/
  Changes    Path          Action
  +14 -9     to_str.c      Modified