Wireshark-commits: [Wireshark-commits] rev 20429: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: etxrab@xxxxxxxxxxxxx
Date: Sun, 14 Jan 2007 20:54:40 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=20429

User: etxrab
Date: 2007/01/14 08:54 PM

Log:
 From Graeme Lunt:
 The problem was that when dissecting the set, if a sub-dissector didn't consume any bytes it was assumed that the correct field hadn't been matched.
 This fix matches the field if the sub-dissector consumes no bytes and we know that the length of the field is zero. This is only allowed on the first pass when we are not matching ANYs.
 I think this is a fairly safe fix - I've tried it with some other ASN.1
 
 I've also changed dissect_ber_octet_string() to show the zero length fields in the dissection. This shows the fields as "<MISSING>" which is not quite the right explanation as the field is definitely present. Something like "<EMPTY>" or "<ZERO LENGTH>" may be better - but I'm not sure of the reasoning behind "<MISSING>".

Directory: /trunk/epan/dissectors/
  Changes    Path            Action
  +6 -2      packet-ber.c    Modified