Wireshark-commits: [Wireshark-commits] rev 19857: /trunk/ /trunk/: capture_loop.c

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: guy@xxxxxxxxxxxxx
Date: Tue, 07 Nov 2006 09:50:10 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=19857

User: guy
Date: 2006/11/07 09:50 AM

Log:
 As Ulf Lamping notes:
 
 	if the pipename argument to cap_pipe_open_live() is null, that's
 	a bug, and we want a crash so it's caught;
 
 	if ld->pcap_h is null in capture_loop_dispatch(), that's a bug,
 	and we want a crash so it's caught;
 
 	if capture_opts is null in capture_loop_start(), that's a bug,
 	and we want a crash so it's caught;
 
 	there's no need to null out capture_opts->save_file twice.
 
 Also, errmsg and secondary_errmsg are null-terminated strings, so the
 array size should be the maximum length + 1.

Directory: /trunk/
  Changes    Path              Action
  +3 -20     capture_loop.c    Modified