Wireshark-commits: [Wireshark-commits] rev 19797: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: sahlberg@xxxxxxxxxxxxx
Date: Sat, 04 Nov 2006 21:19:15 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=19797

User: sahlberg
Date: 2006/11/04 09:19 PM

Log:
 from Dave Richards
 
 
 Here is a patch to fix a problem with notification parameters.  Fix is:
 
 Remove premature return statements from fNotificationParameters.
 
 The real problem is that the original code is inconsistent about putting
 a break in all cases of the switch blocks and some were falling through
 to the default case where there was a return.  I took the simple route
 and removed the unnecessary returns - they were OK for default case but
 not for the fall through.
 
 Is there a standard about having breaks?  If it is desired to have a
 consistent coding style I will further update the code to conform.
 Otherwise, could someone please commit this change as it does fix the bug?
 
 Thanks,
 
 Dave Richards

Directory: /trunk/epan/dissectors/
  Changes    Path               Action
  +0 -2      packet-bacapp.c    Modified