Wireshark-bugs: [Wireshark-bugs] [Bug 13141] TCP options type filed interpreted as IP options ty

Date: Thu, 29 Dec 2016 18:22:03 +0000

Comment # 9 on bug 13141 from
(In reply to Alexis La Goutte from comment #8)
> (In reply to Michael Mann from comment #7)
> > (In reply to Alexis La Goutte from comment #6)
> > > Yes and no...
> > > if there is a Unknown TCP option, it will try to use IP Option "Header" by
> > > default...
> > 
> > I see the mistake.  Working on a fix now (as part of another patch). 
> > Unfortunately I don't see a good solution that's backportable (would require
> > changing signature of dissect_ip_tcp_options).
> 
> I think, there is this issue from (very) longer time... and can wait the
> next major release for be fixed (and not often people say, there is a
> problem...)

I think it "works" because the "tcp.options.type.number" filter has a mask that
still includes correct EOL and NOP option values, but every option for TCP
should really be filterable with "tcp.option_kind".  And changing stable
releases to do that would involve changing dissect_ip_tcp_options() signature. 
That's not something I'm fond of and neither is changing filter names, even if
it is for the better.
I should have a patch for the fix ready today.


You are receiving this mail because:
  • You are watching all bug changes.