Wireshark-bugs: [Wireshark-bugs] [Bug 12951] Implement RFC 6551 dissection in ICMPv6 dissector

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 15 Oct 2016 11:27:01 +0000

Comment # 5 on bug 12951 from 
The errored packet is related to line 2533 in your change of packet-icmpv6.c. 

The (incorrect) length value '1' causes the metric_len variable to underflow,
rolling over to 255. Then it continues to dissect the data as DAG Metric
Container ad infinitum. Or more precisely, until that TVB runs out of data.

This should not happen, as in, your dissector should withstand protocol errors
in the packet it receives (which are the circumstances Wireshark gets called in
to help) as well as possible. Changing this to gint should work fine.

You are receiving this mail because:
  • You are watching all bug changes.