Comment # 9
on bug 12826
from Michael Mann
(In reply to Peter Wu from comment #8)
> Maybe we should drop this data parameter and use p_add_proto_data:
I would rather rewrite the dissector function signature (to have "data pointer
+ type") than use p_add_proto_data. It makes code flow MUCH harder to follow
(and easier to create bugs as a result). It was one of the reasons I tried to
rid dissectors of using pinfo->private_data (and other members than have since
been removed).
For this particular bug, I would prefer that http have 2 function signatures -
one that expects TCP data and one that doesn't. Then both functions would call
a "common" function where necessary TCP data would be passed in (defaulted in
function with NULL data)
You are receiving this mail because:
- You are watching all bug changes.