Wireshark-bugs: [Wireshark-bugs] [Bug 12687] SocketCAN dissector does not support CAN FD

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 14 Aug 2016 19:19:33 +0000

Comment # 27 on bug 12687 from 
(In reply to Guy Harris from comment #25)
> (In reply to Guy Harris from comment #24)
> > (In reply to Oliver Hartkopp from comment #17)
> > > Created attachment 14804 [details]
> > > Patch for libpcap to support CAN FD
> > > 
> > > Taken from libpcap fork at https://github.com/hartkopp/libpcap
> > 
> > You're on GitHub, libpcap's on GitHub - why not just do a pull request?
> 
> BTW, "This branch is 1 commit ahead, 58 commits behind
> the-tcpdump-group:master." - you might want to merge those 58 commits in;
> they *probably* won't affect pcap-can-linux.c, but that way you can make
> sure.

Hello Guy,

sure I could have sent a pull request. But I was not really sure if extending
pcap-can-linux.c in my suggested way is the 'right way' to go.
That's why I first wanted to discuss both changes here.

Regards,
Oliver

You are receiving this mail because:
  • You are watching all bug changes.