[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 10 on bug 12689 from Gerald Combs

(In reply to João Valverde from comment #9)
> (In reply to Gerald Combs from comment #7)
> >
> > I upgraded the fuzz and Ubuntu builders to Xenial. The master-2.0 build is
> > now failing with
> > 
> > /usr/include/gtk-3.0/gtk/deprecated/gtkstyle.h:454:43: error: identifier
> > "and" is a special operator name in C++ [-Werror=c++-compat]
> >  GDK_DEPRECATED_IN_3_0_FOR(GtkStyleContext and gtk_render_background)
> > 
> > Do we need to backport change 14048?
> 
> I can't see any obvious differences as to why this would only occur on
> master-2.0 and I don't recall any patches specifically for this issue.
> 
> The CPP flags for GTK are the same, AFAICT.

It looks like the difference in behavior is due to
https://code.wireshark.org/review/11947, which switched from -I... to
-isystem... for the GTK+ and GLib headers. If I run `$ make V=1 about_dlg.o` in
master on the Ubuntu builder I get:

----
depbase=`echo about_dlg.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -DHAVE_CONFIG_H -I. -I../..  -I../.. -D_FORTIFY_SOURCE=2
-DG_DISABLE_SINGLE_INCLUDES -DG_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED
-DGDK_DISABLE_DEPRECATION_WARNINGS -DGTK_DISABLE_SINGLE_INCLUDES -DGSEAL_ENABLE
-pthread -isystem/usr/include/gtk-3.0 -isystem/usr/include/at-spi2-atk/2.0
-isystem/usr/include/at-spi-2.0 -isystem/usr/include/dbus-1.0
-isystem/usr/lib/x86_64-linux-gnu/dbus-1.0/include -isystem/usr/include/gtk-3.0
-isystem/usr/include/gio-unix-2.0/ -isystem/usr/include/mirclient
-isystem/usr/include/mircommon -isystem/usr/include/mircookie
-isystem/usr/include/cairo -isystem/usr/include/pango-1.0
-isystem/usr/include/harfbuzz -isystem/usr/include/pango-1.0
-isystem/usr/include/atk-1.0 -isystem/usr/include/cairo
-isystem/usr/include/pixman-1 -isystem/usr/include/freetype2
-isystem/usr/include/libpng12 -isystem/usr/include/gdk-pixbuf-2.0
-isystem/usr/include/libpng12 -isystem/usr/include/glib-2.0
-isystem/usr/lib/x86_64-linux-gnu/glib-2.0/include   -Werror -Wall -Wextra
-Wendif-labels -Wpointer-arith -Wformat-security -fwrapv -fno-strict-overflow
-fno-delete-null-pointer-checks -Wvla -Waddress -Wattributes -Wdiv-by-zero
-Wignored-qualifiers -Wpragmas -Wno-overlength-strings -Wno-long-long
-Wc++-compat -Wdeclaration-after-statement -Wshadow -Wno-pointer-sign
-Wold-style-definition -Wstrict-prototypes -Wlogical-op -Wjump-misses-init
-fexcess-precision=fast -fvisibility=hidden -g -O2 -MT about_dlg.o -MD -MP -MF
$depbase.Tpo -c -o about_dlg.o about_dlg.c &&\
mv -f $depbase.Tpo $depbase.Po
----

In master-2.0 I get:

----
depbase=`echo about_dlg.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -DHAVE_CONFIG_H -I. -I../..  -I../.. -I../../wiretap 
-DG_DISABLE_DEPRECATED -DG_DISABLE_SINGLE_INCLUDES -DGSEAL_ENABLE
-DGTK_DISABLE_SINGLE_INCLUDES -DGDK_DISABLE_DEPRECATION_WARNINGS
-DGDK_DISABLE_DEPRECATED  -D_FORTIFY_SOURCE=2 -I/usr/local/include
-I/usr/include -isystem /usr/include/mit-krb5
'-DPLUGIN_INSTALL_DIR="/usr/local/lib/wireshark/plugins/2.0.6"'  -Wall -W
-Wextra -Wendif-labels -Wpointer-arith -Warray-bounds -Wformat-security -fwrapv
-fno-strict-overflow -fno-delete-null-pointer-checks -Wvla -Waddress
-Wattributes -Wdiv-by-zero -Wignored-qualifiers -Wpragmas
-Wno-overlength-strings -Wwrite-strings -Wno-long-long -Wc++-compat
-Wdeclaration-after-statement -Wshadow -Wno-pointer-sign -Wold-style-definition
-Wstrict-prototypes -Wlogical-op -Wjump-misses-init -fexcess-precision=fast
-fvisibility=hidden -g -O2 -I/usr/include/libnl3 
-I/usr/include/x86_64-linux-gnu/qt5/QtCore -I/usr/include/x86_64-linux-gnu/qt5
-I/usr/include/x86_64-linux-gnu/qt5/QtGui -I/usr/include/x86_64-linux-gnu/qt5
-I/usr/include/x86_64-linux-gnu/qt5/QtCore -I/usr/include/x86_64-linux-gnu/qt5
-I/usr/include/x86_64-linux-gnu/qt5/QtWidgets
-I/usr/include/x86_64-linux-gnu/qt5 -I/usr/include/x86_64-linux-gnu/qt5/QtGui
-I/usr/include/x86_64-linux-gnu/qt5 -I/usr/include/x86_64-linux-gnu/qt5/QtCore
-I/usr/include/x86_64-linux-gnu/qt5
-I/usr/include/x86_64-linux-gnu/qt5/QtPrintSupport
-I/usr/include/x86_64-linux-gnu/qt5
-I/usr/include/x86_64-linux-gnu/qt5/QtWidgets
-I/usr/include/x86_64-linux-gnu/qt5 -I/usr/include/x86_64-linux-gnu/qt5/QtGui
-I/usr/include/x86_64-linux-gnu/qt5 -I/usr/include/x86_64-linux-gnu/qt5/QtCore
-I/usr/include/x86_64-linux-gnu/qt5
-I/usr/include/x86_64-linux-gnu/qt5/QtMultimedia
-I/usr/include/x86_64-linux-gnu/qt5
-I/usr/include/x86_64-linux-gnu/qt5/QtNetwork
-I/usr/include/x86_64-linux-gnu/qt5 -I/usr/include/x86_64-linux-gnu/qt5/QtGui
-I/usr/include/x86_64-linux-gnu/qt5 -I/usr/include/x86_64-linux-gnu/qt5/QtCore
-I/usr/include/x86_64-linux-gnu/qt5 -fPIC -pthread -I/usr/include/gtk-3.0
-I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0
-I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include
-I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/mirclient
-I/usr/include/mircommon -I/usr/include/mircookie -I/usr/include/cairo
-I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1
-I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gdk-pixbuf-2.0
-I/usr/include/libpng12 -I/usr/include/glib-2.0
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread -I/usr/include/glib-2.0
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -MT about_dlg.o -MD -MP -MF
$depbase.Tpo -c -o about_dlg.o about_dlg.c &&\
mv -f $depbase.Tpo $depbase.Po
----

If I manually replace "-I/usr/include/gtk" with "-isystem/usr/include/gtk" in
the master-2.0 Makefile it compiles about_dlg.o without any warnings or errors.

---

      You are receiving this mail because:

• You are watching all bug changes.