Comment # 5
on bug 12687
from Michael Mann
(In reply to Oliver Hartkopp from comment #3)
> I'm not really sure if it helps
> as I only can see ETH_P_CAN frames in Wireshark. I've seen the CAN FD frames
> with 'candump vcan0' from can-utils on a separate console though.
I think you have some "file formatting" issues.
SocketCAN has a reserved link type value (227) in the pcap format. That link
type is what ends up calling the socketcan dissector.
The socketcan dissector can also be called through the Linux cooked-mode
capture which also has a reserved link type value (113) in pcap format. It's
in the Linux cooked-mode capture (dissector) that the SLL value of 0xC is used
to call the SocketCAN dissector.
The patches you reference add a SLL value of 0xD for CANFD, but the capture you
provided is in the format of socketCAN, not Linux cooked-mode.
The patch I created (https://code.wireshark.org/review/16787) is just a quick
hack adding 0xD for CANFD. Right now the canfd dissection is exactly the same
as CAN.
If you want to add a reserved link type value for CANFD, you can send an email
to [email protected] asking for a new LINKTYPE_/DLT_ value, and
specifying the purpose of the new value. And if you're successful, we can add
one line in socketcan.c to call the CANFD dissector directly.
You are receiving this mail because:
- You are watching all bug changes.