Wireshark-bugs: [Wireshark-bugs] [Bug 12010] Improve visibility of currently selected packet

Date: Fri, 10 Jun 2016 18:52:53 +0000

Comment # 2 on bug 12010 from
(In reply to Gerrit Code Review from comment #1)
> Change 15816 had a related patch set uploaded by Gerald Combs:
> Qt: Draw a border around inactive+selected packet list items.
> 
> https://code.wireshark.org/review/15816

Are you in fact running Windows 7, and if so are you using the default (Aero)
theme? Of the platforms I have available here, that OS+theme combination has
the most visible inactive+selected packets. Here are the behaviors I see, from
subjectively best to worst:

OS        UI   Inactive+selected style

Windows 7 Qt   Rounded border + gradient background

OS X      Qt   Solid inactive background & foreground 
OS X      GTK+ Solid inactive background & foreground 
Linux     GTK+ Solid inactive background & foreground 
Windows 7 GTK+ Solid inactive background & foreground
Windows 8 GTK+ Solid inactive background & foreground

Windows 8 Qt   Solid tinted active background & foreground
Linux     Qt   Solid *active* background & foreground

Change 15816 draws a solid, square border around the inactive+selected item. It
looks good here on OS X. On Windows 7 + Aero it looks good as well, but it
clobbers the Aero styling, which might not be what we want. If that's not
sufficiently visible there are other tricks we can try such as rounding off the
border or adding our own gradient. Dotted and dashed borders looked ugly in my
tests here so I'd prefer to avoid those. I'd *really* like to avoid any sort of
animation including marching ants or blinking.


You are receiving this mail because:
  • You are watching all bug changes.