Wireshark-bugs: [Wireshark-bugs] [Bug 12422] BACnet decoder incorrectly flags a valid APDU as a

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 11 May 2016 12:58:55 +0000

changed bug 12422


What Removed Added
Status CONFIRMED IN_PROGRESS

Comment # 7 on bug 12422 from 
(In reply to Lori Tribble from comment #6)
> Simple fix in bacapp.c
> 
> Change the decoding of the timestamp to check the array index first.  Here
> is changed code snippet.
> 
>         case 130: /* event-time-stamp */
>             if (propertyArrayIndex == 0) {
>                 /* BACnetARRAY index 0 refers to the length
>                 of the array, not the elements of the array */
>                 offset = fApplicationTypes(tvb, pinfo, tree, offset, ar);
>             } else {
> 	        offset = fEventTimeStamps(tvb, pinfo, tree, offset);
> 	    }
>             break;

Thanks (it is easy when known the how to protocol work)
Can you push your fix ?

You are receiving this mail because:
  • You are watching all bug changes.